Don't use exact versions in peerDependencies #3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
added
dependencies
react-native
vue
patch:yes
# Conflicts: # app/vue/package.json
Codecov Report
@@ Coverage Diff @@
## master #3073 +/- ##
=======================================
Coverage 36.08% 36.08%
=======================================
Files 438 438
Lines 9447 9447
Branches 891 875 -16
=======================================
Hits 3409 3409
- Misses 5456 5498 +42
+ Partials 582 540 -42
Continue to review full report at Codecov.
|
danielduan
approved these changes
Feb 27, 2018
danielduan
approved these changes
Feb 27, 2018
| @@ -72,6 +72,6 @@ | |||
| "babel-core": "^6.26.0 || ^7.0.0-0", | |||
| "babel-runtime": ">=6.0.0", | |||
| "react": "*", | |||
| "react-native": "0.52.2" | |||
| "react-native": ">=0.51.0" | |||
There was a problem hiding this comment.
rn is actually pretty tricky to upgrade. it needs matched versions of all the tooling as well for everything to bundle, compile, and work. I still think this is the right move though.
Hypnosphi
added
patch:done
Hypnosphi
added a commit
that referenced
this pull request
Mar 6, 2018
Don't use exact versions in peerDependencies # Conflicts: # app/react-native/package.json # app/vue/package.json
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: dependencies.io broke our
peerDependencieswith commits like this, setting them to exact version. This makes those peerDeps quite useless3bfbc7a#diff-4c0bffca46303f18a36ec22ddc6e5755R85
Related issue for dependencies.io: https://github.com/dependencies-io/actor-js-lerna/issues/39