Set other manager-side constants in build

[tmeasday]

Issue: DOCS_MODE (and others) weren't getting set.

What I did

Pass options to the htmlTemplate() function and use for these options

How to test

• Check release notes
• Run with --docs
• etc

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c57358f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=8 --max-parallel=15 -- --reset --optimized

---

Sent with 💌 from NxCloud.

[tmeasday]

We seem to apply('features') and await it several times unnecessarily throughout the code base, as we already do this:

storybook/lib/core-server/src/build-dev.ts

Lines 95 to 103 in c57358f

	const features = await presets.apply<StorybookConfig['features']>('features');
	global.FEATURES = features;
	const fullOptions: Options = {
	...options,
	presets,
	features,
	};

The same may be true for logLevel and refs, I'm not sure. I don't pretend to understand this code well enough to say.

[ndelangen]

Evaluating the preset value once, and passing down the value might increase perf by a tiny bit, but at the cost of complexity.

Apply-ing a preset multiple times, is the intended behavior. But what we should do, at some point, is to enable memoization on it, so calling it multiple times with the same options, gets cached.