Preview: Simplify docsMode #18729
Merged
Preview: Simplify docsMode #18729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit efea215. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
tmeasday
commented
Jul 18, 2022
| }, | ||
| layout: { | ||
| initialActive: ActiveTabs.CANVAS, | ||
| showToolbar: !DOCS_MODE, | ||
| showToolbar: true, |
There was a problem hiding this comment.
The toolbar will hide automatically as all entries are docs
Comment on lines
-197
to
-200
| if (DOCS_MODE) { | ||
| api.jumpToComponent(direction); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This happens naturally as all entries are docs, we don't have to skip over any.
| @@ -10,7 +10,6 @@ beforeEach(() => { | |||
| currentState = { | |||
| ui: { | |||
| enableShortcuts: true, | |||
| docsMode: false, | |||
Base automatically changed from
export-other-constants-for-manager
to
future/base
July 18, 2022 12:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #18728What I did
docsfrom the indexDOCS_MODEglobal and instead use props from the providerHow to test
Run react-ts in docs mode and without.
We don't have any e2e tests for docs mode at this stage 😞