Build addons/a11y with ts-up #18772
Merged
Build addons/a11y with ts-up #18772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Ref issue: storybookjs#18732
|
Looks like the build is failing for this package. Checking the issues |
+ There is an issue with the preview file during the linting phase + I manually skipped the linter error for now + The local demo is running fine
ndelangen
approved these changes
Jul 23, 2022
Saunved
commented
Jul 23, 2022
| "types": "./dist/preview.d.ts" | ||
| }, | ||
| "./register.js": { | ||
| "require": "./dist/manager.js", |
There was a problem hiding this comment.
@ndelangen I am confused about why the register export is pointing to ./dist/manager.js
Is it because it actually imports the same file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18732
What I did
Followed the instructions on the issue referenced above. This is my first PR here, so please let me know if I have made any mistakes with the PR process.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.