Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate addons/backgrounds with ts-up #18784

Merged
merged 7 commits into from
Jul 26, 2022
Merged

Generate addons/backgrounds with ts-up #18784

merged 7 commits into from
Jul 26, 2022

Conversation

Saunved
Copy link
Contributor

@Saunved Saunved commented Jul 25, 2022

Issue: #18732

What I did

Followed the instructions in the above issue

How to test

  • Is this testable with Jest or Chromatic screenshots? With CI tests
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@Saunved Saunved added the maintenance User-facing maintenance tasks label Jul 25, 2022
@Saunved Saunved requested a review from ndelangen July 25, 2022 14:55
@ndelangen ndelangen self-assigned this Jul 26, 2022
@ndelangen ndelangen merged commit b0a12ca into next Jul 26, 2022
@ndelangen ndelangen deleted the feat/addons-backgrounds-tsup branch July 26, 2022 08:21
@ndelangen ndelangen mentioned this pull request Jul 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saunved @ndelangen