Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable normalization of package.json #18806

Merged
merged 2 commits into from
Jul 28, 2022
Merged

disable normalization of package.json #18806

merged 2 commits into from
Jul 28, 2022

Conversation

ndelangen
Copy link
Member

Issue: #18791

What I did

fix #18791 and take PackageJson type from an upstream package

@ndelangen ndelangen self-assigned this Jul 28, 2022
@ndelangen ndelangen requested a review from shilman July 28, 2022 13:03
@ndelangen ndelangen added the bug label Jul 28, 2022
@ndelangen
Copy link
Member Author

@lauterry would you mind reviewing this one? 🙏

@ndelangen ndelangen merged commit 7e02352 into next Jul 28, 2022
@ndelangen ndelangen deleted the fix/18791-packagejson-type branch July 28, 2022 15:21
@yannbf yannbf added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jul 28, 2022
@shilman shilman mentioned this pull request Aug 2, 2022
Closed
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Invalid version" on build-storybook
4 participants
@ndelangen @yannbf @valentinpalkovic @shilman