Use a set of test components in addon stories #18825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
changed the base branch from
next
to
tom/sb-581-copy-in-the-rendererframework-specific
tmeasday
commented
Aug 1, 2022
tmeasday
changed the title
tmeasday
force-pushed
the
tom/sb-581-copy-in-the-rendererframework-specific
branch
from
57060ea
to
9495ec0
Compare
tmeasday
force-pushed
the
tom/sb-570-copy-in-the-generic-stories-based-on
branch
from
770188d
to
55b8f56
Compare
tmeasday
force-pushed
the
tom/sb-581-copy-in-the-rendererframework-specific
branch
from
9495ec0
to
d4e108f
Compare
tmeasday
force-pushed
the
tom/sb-570-copy-in-the-generic-stories-based-on
branch
from
55b8f56
to
4dba874
Compare
shilman
reviewed
Aug 1, 2022
Base automatically changed from
tom/sb-581-copy-in-the-rendererframework-specific
to
next
August 2, 2022 01:04
|
Self merging @shilman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Telescoping on #18824
Issue: https://linear.app/chromaui/issue/SB-570/copy-in-the-generic-stories-based-on-chosen-addons-make-them-work-in
What I did
globals.Componentsto drive generic storiesglobals.Componentsvia symlinked (JS-only)template/componentsdirectory inside each renderer.How to test