UI: Fix the order of addons appearing in prebuilt manager #18918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
shilman
changed the title
ndelangen
deleted the
norbert/sb-501-the-order-of-addon-panels-is-not-the
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The addons did not appear in the same order as before, meaning the order in which they are defined in the user's
main.ts.I discovered the reason why:
When I have esbuild write to the file-system, and then read the file-system... The order in which I get them when I read isn't the same as when I wrote.
I changed the behavior to have esbuild NOT write the files to the file-system, when doing so the return value of esbuild contains a
outputFilesproperty. (it does not contain this property when you configure it to write files).This array of files is in the proper order and contains the correct path.