Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Add angular repro template and refactor #18931

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Examples: Add angular repro template and refactor #18931

merged 4 commits into from
Aug 14, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 14, 2022 •
edited by yannbf
Loading

Issue: N/A

What I did

  • Add angular/latest repro
  • Simplify the repro-templates to keep DRY
  • Improve some naming (e.g. generate => generate-repros)

How to test

  • CI passes & repro-templates repo is updated correctly

@shilman shilman added the maintenance User-facing maintenance tasks label Aug 14, 2022
yannbf
yannbf approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@shilman shilman merged commit e9db291 into next Aug 14, 2022
@shilman shilman deleted the shilman/add-angular-repro-template branch August 14, 2022 10:20
@shilman shilman mentioned this pull request Aug 15, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
angular maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @yannbf