Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit sandbox gracefully on cancel #18936

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Exit sandbox gracefully on cancel #18936

merged 2 commits into from
Aug 15, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 15, 2022

Issue: N/A

What I did

When using sandbox and cancelling (e.g. ctrl C) mid prompts:

before:
image

after:
image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Aug 15, 2022
shilman
shilman approved these changes Aug 15, 2022
View reviewed changes
scripts/utils/options.ts Outdated Show resolved Hide resolved
@shilman shilman merged commit e1c59ee into next Aug 15, 2022
@shilman shilman deleted the fix/sandbox-on-cancel branch August 15, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @shilman