Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: use runner with playwright installed for cra_bench #18951

Merged
merged 1 commit into from
Aug 25, 2022
Merged

CI: use runner with playwright installed for cra_bench #18951

merged 1 commit into from
Aug 25, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 17, 2022

Issue: N/A

What I did

The cra_bench step is failing in CI because of missing playwright binaries

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the maintenance User-facing maintenance tasks label Aug 17, 2022
@IanVS IanVS mentioned this pull request Aug 25, 2022
Merged
9 tasks
@ndelangen ndelangen changed the title CI: use playwright on cra_bench CI: use runner with playwright installed for cra_bench Aug 25, 2022
@ndelangen ndelangen merged commit 3b441bf into next Aug 25, 2022
@ndelangen ndelangen deleted the fix/cra-bench-playwright branch August 25, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees

@yannbf yannbf

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yannbf @ndelangen