Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix local repro publishing #18977

Merged
merged 2 commits into from
Aug 22, 2022
Merged

CLI: Fix local repro publishing #18977

merged 2 commits into from
Aug 22, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 22, 2022

Issue: N/A

What I did

To publish using the local registry, always use NPM config.

How to test

In the vite-frameworks branch (which also has this change):

yarn generate-repros-next --template vue3-vite/default-js --local-registry

Before this will fail, after it will succeed

@shilman shilman added maintenance User-facing maintenance tasks cli labels Aug 22, 2022
@shilman shilman requested a review from yannbf August 22, 2022 03:49
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though we should probably revisit this cc @ndelangen

@shilman
Copy link
Member Author

shilman commented Aug 22, 2022

@yannbf I looked at this with @ndelangen and we found:

  • Setting the registry using yarn config works (we're not sure which setting works, since our code set a bunch of them)
  • As soon as you use npm config, however, that will take priority

Based on this information, this PR seems to make sense, even though it feels a bit dirty. Merging for now until somebody comes up with a better solution.

@shilman shilman merged commit de2fd05 into next Aug 22, 2022
@shilman shilman deleted the shilman/fix-local-repro branch August 22, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants