Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally force vite rebuilds in sandbox #19063

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

tmeasday
Copy link
Member

What I did

Add viteFinal to force rebuilds in sandboxes, so it's a little easier to work on SB packages (you still need to restart the SB everytime, but at least that's fast!)

@tmeasday tmeasday requested review from shilman and IanVS August 31, 2022 05:14
@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Aug 31, 2022
@tmeasday tmeasday removed the request for review from shilman August 31, 2022 05:21
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea. I just had one code organization question.

scripts/sandbox.ts Show resolved Hide resolved
@tmeasday tmeasday merged commit 0961a29 into next Sep 1, 2022
@tmeasday tmeasday deleted the tom/sb-698-improve-vite-dev-setup branch September 1, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builder-vite maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants