Ensure if a docs render is torndown during preparation, it throws #19071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementing #17599 for DocsRenderrs
…-vite-storybook-crashes-when
shilman
reviewed
Sep 1, 2022
shilman
changed the title
shilman
approved these changes
Sep 2, 2022
| @@ -1,5 +1,5 @@ | |||
| /// <reference types="@types/jest" />; | |||
|
|
|||
| import { jest, jest as mockJest, it, describe, beforeEach, afterEach, expect } from '@jest/globals'; | |||
There was a problem hiding this comment.
Strictly no, but I prefer it, rather than having global symbols available.
tmeasday
deleted the
tom/sb-699-sb19015-70-vite-storybook-crashes-when
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19015
Implementing #17599 for DocsRenders
What I did
Basically mirrored the behaviour of a story render in a docs render. The contract is, if you call
render.prepare()and thenrender.teardown()before it's done, the prepare should reject with aPREPARE_ABORTED.How to test
XRender.test.tsPreviewWeb.test.tsreact-vite/default-jssandbox and browser to http://localhost:6006. Previously it would error about 50% of the time on my machine.