Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Update to latest nx #19078

Merged
merged 10 commits into from
Sep 7, 2022
Merged

Build: Update to latest nx #19078

merged 10 commits into from
Sep 7, 2022

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Sep 1, 2022 •
edited
Loading

What I did

Update to latest version of Nx

@ndelangen ndelangen self-assigned this Sep 1, 2022
@ndelangen ndelangen added maintenance User-facing maintenance tasks nx Prioritize Nx compatibility for angular labels Sep 1, 2022
@ndelangen
Merge branch 'next' into chore/update-nx-latest
2fbb631 
# Conflicts:
#	code/nx.json
#	code/yarn.lock
@storybookjs storybookjs deleted a comment from github-actions bot Sep 1, 2022
@IanVS
Copy link
Member

IanVS commented Sep 2, 2022

I saw this output in a recent PR's Netlify logs:

STDERR NX As of Nx 13, project configuration should be moved from nx.json to workspace.json/project.json. Please run "nx format" to fix this.

Is that something that should be done here, perhaps? Or, maybe there's a reason not to do it? I don't know much about Nx.

@ndelangen
fix the missing cache of nx
858a434
@ndelangen
Merge branch 'chore/update-nx-latest' of github.com:storybookjs/story…
9b1920d 
…book into chore/update-nx-latest

# Conflicts:
#	code/nx.json
#	code/yarn.lock
@ndelangen ndelangen changed the title draft: update to latest nx - do not merge update to latest nx - do not merge Sep 2, 2022
@ndelangen ndelangen marked this pull request as ready for review September 2, 2022 15:40
@ndelangen ndelangen changed the title update to latest nx - do not merge update to latest nx Sep 2, 2022
@shilman shilman changed the title update to latest nx Build: Update to latest nx Sep 6, 2022
shilman
shilman approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mandarini !!! 🙏

@shilman shilman merged commit 7c8c657 into next Sep 7, 2022
@shilman shilman deleted the chore/update-nx-latest branch September 7, 2022 00:21
@ndelangen
Copy link
Member

@shilman did you intent to merge this?
Angular12 ci/circleci: e2e-tests-core were failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks nx Prioritize Nx compatibility for angular
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mandarini @IanVS @ndelangen @shilman