Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some basic interactions stories #19153

Merged
merged 12 commits into from
Sep 13, 2022
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 9, 2022

and a (crappy) React implemenation of a form

Posting for feedback on the stories and general approach:

  • Are the stories testing everything we need?
  • Is an inline <style> a good idea?

image

Todo

  • Improve form styling
  • Implement form in Vue
  • Implement form in Svelte

NOTE

There is some jankiness in the waitFor stories that highlights problems fixed by #19145

How to test

Should be tested by the CI

@ndelangen
Copy link
Member

Regarding styling:
I think we should keep this as simple as it can possibly be. Static stylesheet referenced outside of any build tool/system.

  • Have a stylesheet somewhere for global styles.
  • Add this as a static path. (we can do this in main.js).
  • Link it in, likely via preview-head.html (I think this can also be done in main.js.

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmeasday
Copy link
Member Author

tmeasday commented Sep 11, 2022

Static stylesheet referenced outside of any build tool/system.

@ndelangen WDYT about something slightly simpler, ie importing CSS in every "form" file. One thing SB guarantees in our docs is you can import CSS:

import './some/path/to/form.css`;

(I'm not sure what the path will be, but does that make sense?)

@tmeasday tmeasday marked this pull request as ready for review September 12, 2022 06:48
@tmeasday
Copy link
Member Author

Move account form stories to official-storybook

@tmeasday
Copy link
Member Author

@shilman I am not sure about the final commit here: 9e3906b -- it needs changes that you have on your docs branches and I am not sure where the overlap between interactions + docs should go.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one clarification

@tmeasday tmeasday merged commit 2454c1c into next Sep 13, 2022
@tmeasday tmeasday deleted the tom/sb-579-addon-interactions branch September 13, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: interactions maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants