Addon-docs: Generic stories for DocsPage #19162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
tmeasday
approved these changes
Sep 11, 2022
Comment on lines
+11
to
+15
| docs: { | ||
| description: { | ||
| component: '**Component** description', | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Should we also have examples that set this stuff via argTypes?
There was a problem hiding this comment.
@tmeasday Added a placeholder, although it's not an especially useful test. We should revisit when we do the annotations server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Generic DocsPage stories. I separated this work from MDX stories which is blocked on #19156
Also @tmeasday note that this reveals a sorting bug in the current implementation #19163
How to test