-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite: Add web-components/lit framework support #19164
Vite: Add web-components/lit framework support #19164
Conversation
@ndelangen the repro generation is failing because it uses
The same commands succeed in production mode, so hopefully we can fix the inconsistency somehow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Maybe this should be lit-vite and generate lit stories?
Do you mean the CLI template should be lit stories? I have no idea, I'm not the right person to ask this!
3c682db
to
e03ecbe
Compare
2eca846
to
af33595
Compare
Socket Security ReportDependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again. 📜 New install scripts detectedA dependency change in this PR is introducing new install scripts to your install step.
🧌 Troll package addedThis package is a joke. You should not use it in production.
Socket.dev scan summary
Bot CommandsTo ignore an alert, reply with a comment starting with
Powered by socket.dev |
Issue: N/A
What I did
How to test