Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbars: Generic example stories #19166

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Toolbars: Generic example stories #19166

merged 4 commits into from
Sep 12, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Sep 11, 2022

Issue: N/A

What I did

  • Add generic toolbars stories for sandboxes

How to test

  • CI passes

@shilman shilman added maintenance User-facing maintenance tasks addon: toolbars labels Sep 11, 2022
tmeasday
tmeasday approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, are you going to delete the other stories?

code/addons/toolbars/template/stories/globals.stories.ts Outdated Show resolved Hide resolved
@shilman shilman merged commit 7b49cae into next Sep 12, 2022
@shilman shilman deleted the shilman/generic-toolbars-stories branch September 12, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
addon: toolbars maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday