TypeScript: Revert a few @ts-expect-errors #19168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Reverts a few lines from #19122
The analysis done by
yarn bootstrap --coreandyarn bootstrap --prepis subtly different, meaning that a few "expect-errors" are not actually errors inbootstrap --prep. As I understand it,yarn bootstrap --corestops analysis at package boundaries, whereasbootstrap --prepactually analyzes across packages (kind of like inlining one package in another), so the results are slightly different.This PR is a workaround to get things moving, since the nightly repro template generation job is currently failing based on these errors. The real fix is to dive into the specific errors and fix them.
Self-merging @IanVS @ndelangen
How to test
Before & after this change: