Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cra-ts-essentials #19170

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Remove cra-ts-essentials #19170

merged 4 commits into from
Sep 13, 2022

Conversation

tmeasday
Copy link
Member

What I did

  • Moved composeStories tests from cra-ts-essentials to renderers/react (we may want to discuss)
  • Remove example

How to test

CI

@tmeasday tmeasday added the maintenance User-facing maintenance tasks label Sep 12, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Still don't like the __test__ convention, but whatever

@tmeasday tmeasday merged commit 6a8157c into next Sep 13, 2022
@tmeasday tmeasday deleted the remove-cra-ts-essentials branch September 13, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants