Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build lib/node-logger with ts-up #19173

Merged
merged 2 commits into from
Sep 14, 2022
Merged

Build lib/node-logger with ts-up #19173

merged 2 commits into from
Sep 14, 2022

Conversation

hayawata3626
Copy link
Member

@hayawata3626 hayawata3626 commented Sep 12, 2022 •
edited
Loading

What I did

Use tsup to build node-logger

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS added maintenance User-facing maintenance tasks core labels Sep 13, 2022
@ndelangen
Merge branch 'next' into build-setting-node-logger
591f4d0 
# Conflicts:
#	code/lib/node-logger/package.json
@ndelangen
Copy link
Member

Thank you!

@ndelangen ndelangen merged commit dcdda17 into storybookjs:next Sep 14, 2022
@hayawata3626 hayawata3626 deleted the build-setting-node-logger branch September 15, 2022 08:11
@shilman shilman mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hayawata3626 @ndelangen @IanVS