Remove cra-kitchen-sink example
#19179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmeasday
commented
Sep 14, 2022
| title: 'Lifecycle', | ||
| }; | ||
|
|
||
| export const Logging = () => <LifecycleLogger />; |
There was a problem hiding this comment.
You needed to check the browser console to see these, and half the methods weren't called anyway. Not sure there was a lot of benefit. If we see problems with react lifecycle, let's create a targetted story with a play() function to verify things work right.
| component: FastRefreshExample, | ||
| }; | ||
|
|
||
| export const Default = () => <FastRefreshExample />; |
There was a problem hiding this comment.
I've no idea what this tested, the component is really generic.
| let count = 0; | ||
| const increment = () => { | ||
| count += 1; | ||
| forceReRender(); |
There was a problem hiding this comment.
We have a story that triggers this event and verifies it.
| }; | ||
|
|
||
| export const Story1 = () => <Button>Hello Button</Button>; | ||
| Story1.storyName = 'with text'; |
There was a problem hiding this comment.
This is a UI unit test style story, 🤷
ndelangen
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This storybook seemed to mainly just have some react rendering testing stories, which were either already created or not actually useful at all (we never looked at them, AFAIK).