Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Bundle lib/docs-tools & lib/instrumenter with ts-up #19206

Merged
merged 10 commits into from
Oct 17, 2022
Merged

Build: Bundle lib/docs-tools & lib/instrumenter with ts-up #19206

merged 10 commits into from
Oct 17, 2022

Conversation

darenbt
Copy link
Contributor

@darenbt darenbt commented Sep 17, 2022

Issue:

Reference: #18732

What I did

Converted lib/docs-tools and lib/instrumenter to use tsup bundling script.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? No

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen
Copy link
Member

Hello @darenbt Thank you for contributing!

I am trying to update your feature branch with new changes in next-branch, but GitHub is refusing:

(build/lib-docs-tools+lib-instrumenter-tsup)⚡ % git push                                                                                                              ~/Projects/Storybook/core/code
Enumerating objects: 44, done.
Counting objects: 100% (44/44), done.
Delta compression using up to 10 threads
Compressing objects: 100% (16/16), done.
Writing objects: 100% (16/16), 2.04 KiB | 2.04 MiB/s, done.
Total 16 (delta 15), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (15/15), completed with 14 local objects.
To https://github.com/darenbt/storybook.git
 ! [remote rejected]       build/lib-docs-tools+lib-instrumenter-tsup -> build/lib-docs-tools+lib-instrumenter-tsup (refusing to allow an OAuth App to create or update workflow `.github/workflows/generate-repros-next.yml` without `workflow` scope)
error: failed to push some refs to 'https://github.com/darenbt/storybook.git'

I don't think there's something you can do to make that work, but perhaps you could merge in next from the upstream remote yourself, to see if the recent changes in next fix the CI issues on this PR? 🙏 Thanks!

@ndelangen ndelangen self-assigned this Oct 5, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Oct 5, 2022
…lib-instrumenter-tsup

# Conflicts:
#	code/lib/docs-tools/package.json
#	code/lib/instrumenter/package.json
@IanVS IanVS requested a review from ndelangen October 7, 2022 19:32
…lib-instrumenter-tsup

# Conflicts:
#	code/lib/docs-tools/package.json
#	code/lib/instrumenter/package.json
@IanVS IanVS changed the title Build lib/docs-tools + lib/instrumenter with ts-up Build: Bundle lib/docs-tools & lib/instrumenter with ts-up Oct 13, 2022
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @darenbt!

code/lib/instrumenter/package.json Outdated Show resolved Hide resolved
code/lib/docs-tools/package.json Outdated Show resolved Hide resolved
@ndelangen ndelangen merged commit 23e2e27 into storybookjs:next Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants