Vite: Do not add Webpack loaders when using Vite builder #19263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
shilman
approved these changes
Sep 27, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
I noticed that the
sb initcommand was adding a vue-loader and svelte-loader even when I'm using a vite-based framework. To prevent this, while keeping the original behavior for webpack projects, I updated the generators to only add the extra packages when webpack is being used.How to test
Build the branch (necessary?), then run
yarn generate-repros-next --local-registry. Check the/repros/svelte-vite/default-jsdirectory and verify thatsvelte-loaderis not inpackage.json. Similarly for the vue3 repro.