Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: forward parameters in command execution #19283

Merged
merged 1 commit into from
Oct 3, 2022
Merged

chore: forward parameters in command execution #19283

merged 1 commit into from
Oct 3, 2022

Conversation

mandarini
Copy link
Contributor

@mandarini mandarini commented Sep 28, 2022 •
edited
Loading

What I did

  • Changed nx.json schema to use targetDefaults instead of targetDependencies, so that we can take advantage of forwarding parameters.
  • Added "params": "forward" to the prep task

Read:

How to test

  • Are parameters correctly passed down the commands?
  • Is everything working as expected?

@mandarini mandarini marked this pull request as ready for review September 28, 2022 16:50
@yannbf yannbf added the maintenance User-facing maintenance tasks label Sep 28, 2022
@yannbf
Copy link
Member

yannbf commented Sep 28, 2022

You're the absolute best @mandarini !!

@ndelangen ndelangen merged commit 0b3682b into next Oct 3, 2022
@ndelangen ndelangen deleted the chore/target-defaults branch October 3, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandarini @yannbf @ndelangen