Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable smoke test on cra/default-ts #19352

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Disable smoke test on cra/default-ts #19352

merged 5 commits into from
Oct 5, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 5, 2022

See #19351

@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Oct 5, 2022
@tmeasday tmeasday requested a review from shilman October 5, 2022 00:49
shilman
shilman approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ndelangen ndelangen merged commit 33f942b into next Oct 5, 2022
@ndelangen ndelangen deleted the disable-cra-default-ts-smoke-test branch October 5, 2022 07:24
@shilman shilman mentioned this pull request Oct 5, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmeasday @shilman @ndelangen