Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Bundle lib/codemod with ts-up #19398

Merged
merged 5 commits into from
Oct 17, 2022
Merged

Build: Bundle lib/codemod with ts-up #19398

merged 5 commits into from
Oct 17, 2022

Conversation

Platiplus
Copy link
Contributor

@Platiplus Platiplus commented Oct 7, 2022 •
edited by ndelangen
Loading

Related: 18732

What I did

  • Changed package.json file to migrate to ts-up

@socket-security
Copy link

socket-security bot commented Oct 7, 2022 •
edited
Loading

Socket Security Report

👍 No new dependency issues detected in pull request

Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ✅ no new install scripts
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@Platiplus
Copy link
Contributor Author

Hi @IanVS! Thanks for letting me work on this! It seems the build is failing for some reasons unrelated to the code change, can you check? Thanks!!! ⚡

@IanVS IanVS added the build Internal-facing build tooling & test updates label Oct 8, 2022
@IanVS IanVS changed the title [18732] - Migrating Codemod to TS-UP Build: Bundle lib/codemod with ts-up Oct 8, 2022
@Platiplus
Copy link
Contributor Author

Hi @IanVS! Anything I can do related to those failed steps on CI? Lemme know if I can help somehow!

@IanVS
Copy link
Member

IanVS commented Oct 9, 2022

I don't think so, no. I think we need to wait until CI is fixed in general.

@IanVS IanVS mentioned this pull request Oct 13, 2022
Closed
@IanVS
Merge remote-tracking branch 'origin/next' into 18732-migrating-codem…
ffcd632 
…od-to-ts-up

# Conflicts:
#	code/lib/codemod/package.json
@Platiplus Platiplus requested a review from IanVS October 13, 2022 17:29
@ndelangen ndelangen merged commit 77638cd into storybookjs:next Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Platiplus @IanVS @ndelangen