Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Improve template stories #19402

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Build: Improve template stories #19402

merged 7 commits into from
Oct 11, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Oct 8, 2022

Issue: N/A

What I did

Small improvements in the CI setup:

  • Improve addon-links stories
  • Improve addon-viewport story
  • Improve setup name in the addon-interactions stories
  • Upgrade eslint-plugin-storybook

@yannbf yannbf added the build Internal-facing build tooling & test updates label Oct 8, 2022
@shilman shilman changed the title Small improvements to template stories Build: Improve template stories Oct 9, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yannbf Nice one! But it looks like the new version of eslint has detected some problems in the stories. Can you please get it green?

@yannbf
Copy link
Member Author

yannbf commented Oct 10, 2022

@yannbf Nice one! But it looks like the new version of eslint has detected some problems in the stories. Can you please get it green?

For sure! Happy to see that it detected bugs so we can improve it 💃 but not happy about the bugs haha

@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (added) postinstall code/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],code/examples/angular-cli/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],scripts/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected]
🧌 Troll package added

This package is a joke. You should not use it in production.

Package Note Location
[email protected] (added) This package prints a protestware console message on install regarding Ukraine for users with Russian language locale code/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],code/examples/angular-cli/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],scripts/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ⚠️ 1 new troll package detected
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@yannbf yannbf assigned ndelangen and yannbf and unassigned ndelangen Oct 10, 2022
@yannbf yannbf merged commit b52c30a into next Oct 11, 2022
@yannbf yannbf deleted the fix/small-improvements branch October 11, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants