Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable preact templates and remove preact-kitchen-sink #19454

Merged
merged 11 commits into from
Oct 17, 2022
Merged

Enable preact templates and remove preact-kitchen-sink #19454

merged 11 commits into from
Oct 17, 2022

Conversation

tmeasday
Copy link
Member

Telescoping on #19451

What I did

  • Enabled templates added above
  • Copied over react compat story
  • Removed preact-kitchen-sink example

How to test

  • CI passes
  • Check stories are represented in template sandboxes.

@tmeasday tmeasday added preact build Internal-facing build tooling & test updates labels Oct 12, 2022
Base automatically changed from tom/sb-557-typescript-2 to next October 13, 2022 03:47
shilman
shilman approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tmeasday tmeasday merged commit 5cadf8d into next Oct 17, 2022
@tmeasday tmeasday deleted the tom/sb-706-migrate-stories-and-delete-preact branch October 17, 2022 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@KrofDrakula KrofDrakula Awaiting requested review from KrofDrakula

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates preact
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman