Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to use node 16 everywhere #19458

Merged
merged 6 commits into from
Oct 13, 2022
Merged

upgrade to use node 16 everywhere #19458

merged 6 commits into from
Oct 13, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 12, 2022 •
edited
Loading

  • upgrade the monorepo to use node16
  • compile everything for node 16
  • compile everything with node 16
  • run all CI in node 16

@ndelangen ndelangen self-assigned this Oct 12, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Oct 12, 2022
@ndelangen
Copy link
Member Author

ndelangen commented Oct 12, 2022 •
edited
Loading

Looks like some things are actually broken

actually looks like it's happening on next, as well.

@ndelangen
Copy link
Member Author

fixing the problems here:
#19461

@ndelangen
Copy link
Member Author

Looks like there's something about angular example not liking node 16
And in addition to that it seems node16 takes just a bit more power which trips CircleCI into killing it.

@ndelangen
Copy link
Member Author

removing the angular example is on the table:
#19467

@ndelangen ndelangen merged commit acb3ed1 into next Oct 13, 2022
@ndelangen ndelangen deleted the tech/use-node-16 branch October 13, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

@tmeasday tmeasday Awaiting requested review from tmeasday

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

Assignees

@ndelangen ndelangen

Labels
maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndelangen