Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass the full path to repro generators #19480

Merged
merged 4 commits into from
Oct 14, 2022
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 13, 2022

Issue: Repro generation was hanging as yarn create vite prompts if you pass an absolute path

What I did

Just path the relative path and run from inside the temp dir

How to test

I'll kick off a repro generation

@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Oct 13, 2022
@tmeasday tmeasday merged commit 15e534a into next Oct 14, 2022
@tmeasday tmeasday deleted the fix-repro-generation branch October 14, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants