Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move examples -> test-storybooks #19599

Merged
merged 8 commits into from
Oct 25, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Oct 24, 2022

  • Move examples
  • Link them (and clean out code/'s deps)
  • Remove Circle Jobs for examples

The plan is to add new circle jobs to e.g. E2E test, or run Chromatic against these examples. I haven't done that yet as I am not sure which ones we want to test. Currently on next the only remaining example SB we run Chromatic against is the doc-blocks repo, which is the one I am expecting @JReinhold to delete soon.

Note for example that AFAIK the ember example doesn't work right now due to framework issues.

PS code/node_modules goes from 2.2->1.8G which should help a little with circle times amongst other things.

@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Oct 24, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 x 💯

@tmeasday tmeasday force-pushed the tom/sb-813-move-remaining-examples-to-old-examples branch from e7356d5 to 0c9e1ed Compare October 25, 2022 04:53
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (added) postinstall code/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],scripts/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected]
🧌 Troll package added

This package is a joke. You should not use it in production.

Package Note Location
[email protected] (added) This package prints a protestware console message on install regarding Ukraine for users with Russian language locale code/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected],scripts/package.json via @compodoc/[email protected], [email protected], @foliojs-fork/[email protected], [email protected], [email protected], [email protected], [email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ⚠️ 1 new troll package detected
Malware ✅ no new malware
Native code ✅ no new native modules
Bin Script Confusion ✅ no new bin script confusions
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@tmeasday tmeasday force-pushed the tom/sb-813-move-remaining-examples-to-old-examples branch from 0c9e1ed to 9a92922 Compare October 25, 2022 05:01
@tmeasday tmeasday merged commit 03551d1 into next Oct 25, 2022
@tmeasday tmeasday deleted the tom/sb-813-move-remaining-examples-to-old-examples branch October 25, 2022 05:38
@JReinhold
Copy link
Contributor

@tmeasday I think this PR broke Netlify deployments. See this PR's deployments at https://app.netlify.com/sites/storybookjs/deploys/63576db9580f310009ed9701:

7:05:38 AM: ​
7:05:38 AM: ────────────────────────────────────────────────────────────────
7:05:38 AM:   Configuration error                                           
7:05:38 AM: ────────────────────────────────────────────────────────────────
7:05:38 AM: ​
7:05:38 AM:   Error message
7:05:38 AM:   Deploy did not succeed: Deploy directory 'code/built-storybooks' does not exist
7:05:38 AM: ​
7:05:38 AM:   Resolved config
7:05:38 AM:   build:
7:05:38 AM:     command: yarn task --task compile --start-from=auto --no-link
7:05:38 AM:     commandOrigin: config
7:05:39 AM:     environment:
7:05:39 AM:       - NODE_VERSION
7:05:39 AM:       - REVIEW_ID
7:05:39 AM:       - YARN_VERSION
7:05:39 AM:       - DOTENV_DISPLAY_WARNING
7:05:39 AM:       - STORYBOOK_EXAMPLE_APP
7:05:39 AM:     publish: /opt/build/repo/code/built-storybooks
7:05:39 AM:     publishOrigin: config
7:05:39 AM:   headers:
7:05:39 AM:     - for: /*

It is looking for code/built-storybooks and maybe this PR moves them to another directory?

@tmeasday
Copy link
Member Author

Yes it sure did! Discussed with @shilman he told me we are going to figure it out w/ @ndelangen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants