Fix broken stories in UI Storybook #19632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
approved these changes
Oct 26, 2022
| "storybook:ui": "./lib/cli/bin/index.js dev --port 6006 --config-dir ./ui/.storybook --no-manager-cache", | ||
| "storybook:ui:build": "./lib/cli/bin/index.js build --config-dir ./ui/.storybook", | ||
| "storybook:ui": "NODE_OPTIONS=\"--preserve-symlinks --preserve-symlinks-main\" ./lib/cli/bin/index.js dev --port 6006 --config-dir ./ui/.storybook --no-manager-cache", | ||
| "storybook:ui:build": "NODE_OPTIONS=\"--preserve-symlinks --preserve-symlinks-main\" ./lib/cli/bin/index.js build --config-dir ./ui/.storybook", |
There was a problem hiding this comment.
You should probably cd into the ui directory & run storybook from there. Though I'm not 100% sure it's required.
There was a problem hiding this comment.
It's actually on purpose we don't do that, because Vite will look for node_modules in cwd, and since they're all at code/node_modules we have to run from code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with a few stories in our UI Storybook that was caused by symlinks as suggested here #19598 (comment)
Most notably Emotion conflicts and
SyntaxHighlighter 2 is undefined- reported asQtin Chromatic because of minification.Eg. see the Chromatic build here for an example of a fixed story: https://www.chromatic.com/test?appId=635781f3500dd2c49e189caf&id=635930a76623c00ed5f85ae3
CC @shilman this is the problem we were debugging a few days ago.