move the actions decorator into it's own entrypoint #19650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonniebigodes
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
This is great. Thanks for taking the time to update the documentation. Appreciate it 🙏 ! I'll defer to @shilman for his feedback, but from my end it's good to go.
|
@jonniebigodes Do you think we should add something to the MIGRATION.md ? <- @shilman same question really |
|
@ndelangen yes, please, adding it will only help us. |
ndelangen
deleted the
norbert/sb-803-resolve-addon-actions-deprecations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the withActions decorator was deprecated, but actually critial to make it work for the html renderer.
I've extracted the decorator into it's own entrypoint, and added documentation on how to now best use it.