Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Migrate CLI templates to CSF3 #19665

Merged
merged 4 commits into from
Nov 1, 2022
Merged

CLI: Migrate CLI templates to CSF3 #19665

merged 4 commits into from
Nov 1, 2022

Conversation

kasperpeulen
Copy link
Contributor

Telescoping on #19664

What I did

  • Migrated all cli templates to CSF3

How to test

  • Testing is a bit difficult, maybe we can make a canary built for this PR @shilman I used verdaccio locally together with Norbert.

@kasperpeulen kasperpeulen changed the title CLI: Migrate cli templates to CSF3 CLI: Migrate CLI templates to CSF3 Oct 28, 2022
@kasperpeulen kasperpeulen mentioned this pull request Oct 28, 2022
Closed
@shilman
Copy link
Member

shilman commented Oct 28, 2022

@kasperpeulen we don't have a mechanism for canary builds. only alphas currently. if you can get CI passing, I can release this in an alpha.

@kasperpeulen kasperpeulen force-pushed the kasper/cli-templates branch 9 times, most recently from a481eec to 6c02686 Compare October 29, 2022 07:30
@kasperpeulen kasperpeulen force-pushed the kasper/cli-templates branch 3 times, most recently from a12c002 to d236c89 Compare October 30, 2022 06:37
@kasperpeulen kasperpeulen force-pushed the kasper/templates-to-csf3 branch 3 times, most recently from 29ce7ea to 15631b2 Compare October 30, 2022 14:42
@kasperpeulen kasperpeulen force-pushed the kasper/cli-templates branch 2 times, most recently from 3d745ec to 960426d Compare October 31, 2022 09:59
Base automatically changed from kasper/cli-templates to next November 1, 2022 01:24
shilman
shilman approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff @kasperpeulen !! Great job 💯

@shilman shilman merged commit bf5ec56 into next Nov 1, 2022
@shilman shilman deleted the kasper/templates-to-csf3 branch November 1, 2022 02:07
@jonniebigodes jonniebigodes mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@shilman shilman

Labels
csf3 feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @shilman