Build: Bundle lib/channel-websocket with tsup #19694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanjtc
changed the title
bryanjtc
force-pushed
the
tsup-lib-channel-websocket
branch
2 times, most recently
from
e6892b4
to
22fe7ff
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bryanjtc
force-pushed
the
tsup-lib-channel-websocket
branch
from
22fe7ff
to
abfcee6
Compare
kasperpeulen
added
maintenance
|
CI is green. @ndelangen Is there something missing or everything it's ok? |
ndelangen
approved these changes
Nov 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18732
What I did
Followed the instructions in the above issue
How to test
If your answer is yes to any of these, please make sure to include it in your PR.