Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add docsPage to all Button/Header story templates #19715

Merged
merged 2 commits into from
Nov 2, 2022
Merged

CLI: Add docsPage to all Button/Header story templates #19715

merged 2 commits into from
Nov 2, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Nov 2, 2022 •
edited
Loading

Issue: N/A

What I did

  • Use tags to opt-in to docsPage for Button + Header components
  • Set docsPage: true in default main.js

How to test

I ran the cli init command against a local repro to verify the main.js changes.

@tmeasday tmeasday requested a review from shilman November 2, 2022 06:15
shilman
shilman approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this ❤️

@shilman shilman changed the title Add docsPage tag to all Button/Header CLI templates CLI: Add docsPage to all Button/Header story templates Nov 2, 2022
@shilman shilman added the cli label Nov 2, 2022
@shilman shilman merged commit 35610ab into next Nov 2, 2022
@shilman shilman deleted the tom/sb-897-update-cli-template-to-set-autodocspage branch November 2, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
addon: docs cli feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman