Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Delete node_modules in repro generation #19734

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Maintenance: Delete node_modules in repro generation #19734

merged 2 commits into from
Nov 2, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 2, 2022

Issue: N/A

What I did

GH repros action was broken due to space limits. This PR fixes that by removing node_modules when running yarn generate-repros in CI.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Nov 2, 2022
@yannbf yannbf changed the title delete node_modules once repro is generated Maintenance: Delete node_modules in repro generation Nov 2, 2022
@yannbf
Copy link
Member Author

yannbf commented Nov 2, 2022

Self merging @shilman

@yannbf yannbf merged commit c18d0c3 into next Nov 2, 2022
@yannbf yannbf deleted the chore/fix-repro-generation branch November 2, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yannbf