Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Cancel workflow in CI on steps failure #19748

Merged
merged 9 commits into from
Nov 4, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 3, 2022

Issue: N/A

What I did

This PR does a couple of things:

  1. Merges the publish and build steps into one. There's no reason to have them run separately, and this saves time (about 20 seconds).

  2. Adds a new command which is attached to the critical jobs:
    [ check, lint, unit-tests, script-unit-tests ]

And if any of them failed, it will cancel the entire workflow. This way we don't spend unnecessary time running a bunch of sandbox/e2e tests in case the basic checks are failing, and they should be quickly fixed.

Here's an example when I forced a unit test failure:
image

Therefore, the entire run took less than 5 minutes instead of 20 minutes (including a bunch of unnecessary sandbox scripts that got executed)

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Nov 3, 2022
@yannbf yannbf changed the title Chore/cancel workflow on failure Maintenance: cancel workflow in CI on steps failure Nov 3, 2022
@yannbf yannbf marked this pull request as ready for review November 4, 2022 09:49
@yannbf yannbf requested a review from ndelangen November 4, 2022 09:52
@kasperpeulen kasperpeulen changed the title Maintenance: cancel workflow in CI on steps failure Maintenance: Cancel workflow in CI on steps failure Nov 4, 2022
@yannbf yannbf merged commit afc8d39 into next Nov 4, 2022
@yannbf yannbf deleted the chore/cancel-workflow-on-failure branch November 4, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants