Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepare script on Windows machines #19762

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Fix prepare script on Windows machines #19762

merged 1 commit into from
Nov 6, 2022

Conversation

valentinpalkovic
Copy link
Contributor

Issue: On windows machines the prepare script produces index.d.ts files with Windows path separators, instead of POSIX ones.

What I did

On Windows machines POSIX paths are generated for index.d.ts files.

How to test

  • Run yarn task on a windows machine and select "Compile the source code of the monorepo (compile)"
  • All dependencies should be installed. All 82 prep tasks should run successfully

@valentinpalkovic valentinpalkovic added the build Internal-facing build tooling & test updates label Nov 6, 2022
kasperpeulen
kasperpeulen approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kasperpeulen kasperpeulen merged commit d6d7a50 into next Nov 6, 2022
@kasperpeulen kasperpeulen deleted the valentin/fix-windows-prep-build branch November 6, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperpeulen kasperpeulen kasperpeulen approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @kasperpeulen