Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mdx2-csf to fix mdxSource generation #19766

Merged
merged 2 commits into from
Nov 7, 2022
Merged

Upgrade mdx2-csf to fix mdxSource generation #19766

merged 2 commits into from
Nov 7, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 7, 2022 •
edited
Loading

Issue: #18342

What I did

  • Update lockfile
  • Add sandbox example

@tmeasday self-merging & assuming chromatic failure is test flake

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman marked this pull request as ready for review November 7, 2022 07:32
@shilman shilman merged commit 6f2d930 into next Nov 7, 2022
@shilman shilman deleted the shilman/mdx2-fix-mdx-source branch November 7, 2022 07:33
@shilman shilman mentioned this pull request Nov 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies mdx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shilman