Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use a new cadence (ci, pr, merged, daily) and trigger CircleCI from github actions #19768

Merged
merged 3 commits into from
Nov 8, 2022
Merged

CI: Use a new cadence (ci, pr, merged, daily) and trigger CircleCI from github actions #19768

merged 3 commits into from
Nov 8, 2022

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Nov 7, 2022 •
edited
Loading

What I did

  • Made a new cadence: ci, pr, merged, daily
  • Trigger those cadences from github actions
  • Labels can be used to override the default behavior

How to test

  • Try adding labels to this PR, and see it being triggered
  • Move the PR to draft, and back to ready for review
  • Trigger workflows from the circle ci API or web UI by passing workflow is ci, pr, merged or daily

@kasperpeulen kasperpeulen added the build Internal-facing build tooling & test updates label Nov 7, 2022
@kasperpeulen kasperpeulen marked this pull request as ready for review November 7, 2022 15:42
@kasperpeulen kasperpeulen marked this pull request as draft November 7, 2022 19:26
@kasperpeulen kasperpeulen marked this pull request as ready for review November 7, 2022 19:26
@kasperpeulen kasperpeulen changed the title WIP: Use ci, pr, merged, daily cadence CI: Use a new cadence (ci, pr, merged, daily) and trigger those workflows from github actions Nov 8, 2022
@kasperpeulen kasperpeulen changed the title CI: Use a new cadence (ci, pr, merged, daily) and trigger those workflows from github actions CI: Use a new cadence (ci, pr, merged, daily) and trigger this cadence from github actions Nov 8, 2022
@kasperpeulen kasperpeulen changed the title CI: Use a new cadence (ci, pr, merged, daily) and trigger this cadence from github actions CI: Use a new cadence (ci, pr, merged, daily) and trigger CircleCI from github actions Nov 8, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 8, 2022 08:39
@kasperpeulen kasperpeulen marked this pull request as ready for review November 8, 2022 08:40
@kasperpeulen kasperpeulen added the ci:merged Run the CI jobs that normally run when merged. label Nov 8, 2022
@kasperpeulen kasperpeulen added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:merged Run the CI jobs that normally run when merged. ci:daily Run the CI jobs that normally run in the daily job. labels Nov 8, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 8, 2022 08:47
@kasperpeulen kasperpeulen marked this pull request as ready for review November 8, 2022 08:58
@kasperpeulen kasperpeulen self-assigned this Nov 8, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 8, 2022 09:47
@kasperpeulen kasperpeulen marked this pull request as ready for review November 8, 2022 09:55
@kasperpeulen kasperpeulen added the ci:daily Run the CI jobs that normally run in the daily job. label Nov 8, 2022
@kasperpeulen kasperpeulen added ci:merged Run the CI jobs that normally run when merged. and removed ci:daily Run the CI jobs that normally run in the daily job. ci:merged Run the CI jobs that normally run when merged. labels Nov 8, 2022
@kasperpeulen kasperpeulen marked this pull request as draft November 8, 2022 13:00
@kasperpeulen kasperpeulen marked this pull request as ready for review November 8, 2022 13:01
@kasperpeulen kasperpeulen marked this pull request as draft November 8, 2022 13:02
@kasperpeulen kasperpeulen removed the ci:pr label Nov 8, 2022
yannbf
yannbf reviewed Nov 8, 2022
View reviewed changes
.circleci/config.yml
requires:
- build
# - smoke-test-sandboxes: # disabled for now
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to create an issue to resolve this (reenable when whatever blocker is blocking this gets resolved), else we might forget entirely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, added an linear ticket in our project

@kasperpeulen kasperpeulen marked this pull request as ready for review November 8, 2022 16:14
@kasperpeulen kasperpeulen merged commit 0362b4e into next Nov 8, 2022
@kasperpeulen kasperpeulen deleted the kasper/ci-pr-workflow branch November 8, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@shilman shilman Awaiting requested review from shilman

Assignees

@kasperpeulen kasperpeulen

Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kasperpeulen @yannbf