Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix showPanel=false doesn't work on mobile view #19807

Merged
merged 4 commits into from
Nov 17, 2022
Merged

UI: Fix showPanel=false doesn't work on mobile view #19807

merged 4 commits into from
Nov 17, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Nov 11, 2022 •
edited by shilman
Loading

Issue: #18386

What I did

  • Support options.showPanel in code/ui/manager/src/components/layout/mobile.tsx

How to test

Run a sandbox in development mode with new manager.js

// sandbox/react-vite-default-ts/.storybook/manager.js
import { addons } from '@storybook/addons';

addons.setConfig({ showPanel: false });

Switch to mobile view and verify the Addons tabs is removed from bottom tabs bar

@gitstart gitstart marked this pull request as ready for review November 11, 2022 15:58
@shilman shilman changed the title fix: showPanel=false doesn't work on mobile view UI: Fix showPanel=false doesn't work on mobile view Nov 14, 2022
JReinhold
JReinhold approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@JReinhold JReinhold merged commit 7ca44e3 into storybookjs:next Nov 17, 2022
@gitstart
Copy link
Contributor Author

gitstart commented Nov 17, 2022 •
edited
Loading

PR pushed through Gitstart with contributions from @BikashSah999 @raph941 @phunguyenmurcul

@shilman shilman mentioned this pull request Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JReinhold JReinhold JReinhold approved these changes

Assignees

@JReinhold JReinhold

Labels
bug ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gitstart @JReinhold @shilman