Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: improve error reporting mechanism #19841

Merged
merged 8 commits into from
Nov 16, 2022
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 15, 2022

Issue:

What I did

  • Improved the discord report message based on workflow, job, branch:
    • For the alpha branch, it will provide the Storybook version
    • For the chromatic-sandboxes job, it will ask the maintainer to check the visual diff, as it might not be a bug
    • For merged workflow, it will only show a single PR in the relevant PRs section
    • For the rest, which will be the daily workflow, it will show PRs from the past 24 hours
  • Added reporting for all steps

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added the build Internal-facing build tooling & test updates label Nov 15, 2022
@yannbf yannbf marked this pull request as ready for review November 15, 2022 11:19
scripts/get-report-message.ts Outdated Show resolved Hide resolved
@kasperpeulen kasperpeulen self-requested a review November 15, 2022 14:18
@yannbf yannbf changed the title Chore: improve reporting mechanism CI: improve error reporting mechanism Nov 16, 2022
@yannbf yannbf merged commit cd646a6 into next Nov 16, 2022
@yannbf yannbf deleted the yann/improve-reporting-mechanism branch November 16, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants