Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest: switch from Parameters to StorybookInternalParameters #19853

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Nov 16, 2022

Issue: N/A

What I did

  • There was a type change which moved fileName away from Parameters. This PR adjusts the type to the newly added StorybookInternalParameters type.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@yannbf yannbf added maintenance User-facing maintenance tasks addon: jest labels Nov 16, 2022
@kasperpeulen kasperpeulen self-requested a review November 16, 2022 14:25
Copy link
Contributor

@kasperpeulen kasperpeulen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why this was not found in my PR.

There are probably more places where we can use this type, but I wanted to do that in another ticket, where we really gonna find the right types for all Parameters (including all addons in the monorepo).

@kasperpeulen kasperpeulen merged commit 148eb7d into next Nov 16, 2022
@kasperpeulen kasperpeulen deleted the yann/fix-types-in-jest-addon branch November 16, 2022 15:36
@yannbf yannbf added the linear label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: jest maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants