UI Storybook: Disable sourcemaps when building in CI #19862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanVS
approved these changes
Nov 16, 2022
IanVS
reviewed
Nov 16, 2022
| build: { | ||
| ...viteConfig.build, | ||
| // disable sourcemaps in CI to not run out of memory | ||
| sourcemap: process.env.CI !== 'true', |
There was a problem hiding this comment.
I verified that CircleCI sets it to "true" and not just "1" or something. https://circleci.com/docs/variables/#built-in-environment-variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable sourcemaps when building the UI and Blocks Storybooks in CI, in an attempt to fix the issue with running out of memory.
Example of a failed pipeline: https://app.circleci.com/pipelines/github/storybookjs/storybook/32439/workflows/fc163113-af9a-4919-9699-84407170251e/jobs/442029