Build a mechanism to E2E telemetry #19946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
approved these changes
Nov 24, 2022
| ); | ||
| } | ||
|
|
||
| const expectation = eventTypeExpectations[eventType as keyof typeof eventTypeExpectations]; |
There was a problem hiding this comment.
What is the purpose of this variable?
There was a problem hiding this comment.
Oh, my thought was that we might have some sort of event-specific checks that could be driven by this object. Alternatively we could make it a function that does it's own assertions on the mainEvent (that's probably better now I think about it).
|
Will update later with some changes but for now this is doing something useful! |
tmeasday
deleted the
tom/sb-844-turn-on-telemetry-for-sandboxes-test-in
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: NA
What I did
buildevent (the only one we currently trigger in our CI process), which really just checks the very basics.We should consider if/how we are going to test some other telemetry events, and whether we want to do it per-sandbox:
initupgradedev[this one should be done with smoke testing soon).errorerror-metadata.How to test
CI passes