change export-generating script to use exec util over shelljs #19979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, not sure why it would have broken but change seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
I’m getting some build to fail over git diffs on generated code.
Code that should be generated during a pre command ran when a package is bundled.
Somehow the command isn’t awaited on? Or something else is failing, but not being detected.
Re-running the CI job works, but there’s some sort of race condition for sure.
What I did
I changed the code so it uses our exec util from scripts.
I probably should move this localized script into the scripts directory?
I did not change the one in lib/preview, because it's about to get deleted:
#19978