Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade yarn #20025

Merged
merged 5 commits into from
Nov 30, 2022
Merged

upgrade yarn #20025

merged 5 commits into from
Nov 30, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 30, 2022

Issue:
The sandboxes are installing the latest version of yarn, whereas we use something slightly older

What I did

upgrade to latest version of yarn,
de-duplicate the yarn installation

@ndelangen ndelangen self-assigned this Nov 30, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Nov 30, 2022
@ndelangen
Copy link
Member Author

@kasperpeulen this check issue seems like something you might be able to assist with?

Would you be able to have a look at what's wrong?

At a first glance, it looks like vue JSX types get confused with vue JSX types.

@ndelangen
Copy link
Member Author

ndelangen commented Nov 30, 2022

@kasperpeulen

I don't quite understand what's going on here:
code/renderers/vue/src/public-types.test.ts

Screenshot 2022-11-30 at 11 56 36

@kasperpeulen
Copy link
Contributor

Checking it out

@kasperpeulen
Copy link
Contributor

kasperpeulen commented Nov 30, 2022

@ndelangen I fixed the issue by making sure module augmentation is a bit more explicit throughout the monorepo, and only using the global types of jest by default:
1db0da7 (#20025)

@ndelangen
Copy link
Member Author

@kasperpeulen Is this new?:

ERR! You may need an additional loader to handle the result of these loaders.
ERR! |     layout: 'fullscreen'
ERR! |   }
ERR! > } satisfies Meta<typeof Page>);
ERR! | export default meta;
ERR! | export var LoggedOut = {};
ERR! Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

@kasperpeulen
Copy link
Contributor

dkasperpeulen Yes, it is new, investigating, but having a hard time, see discord. Maybe I should just delete the next TS 4.9 templates for now.

@ndelangen ndelangen merged commit 98262c5 into next Nov 30, 2022
@ndelangen ndelangen deleted the tech/upgrade-yarn branch November 30, 2022 12:37
@ndelangen
Copy link
Member Author

@shilman @kasperpeulen self merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants